A zero discard_granularity is not treated the same as a single-block one,
and not having any segments after taking alignment is perfectly fine
and does not need a warning.

Signed-off-by: Christoph Hellwig <h...@lst.de>
---
 block/blk-merge.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/block/blk-merge.c b/block/blk-merge.c
index 65e75efa9bd366..2d470cf2173e29 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -115,17 +115,13 @@ static struct bio *bio_split_discard(struct bio *bio,
 
        *nsegs = 1;
 
-       /* Zero-sector (unknown) and one-sector granularities are the same.  */
        granularity = max(lim->discard_granularity >> 9, 1U);
 
        max_discard_sectors =
                min(lim->max_discard_sectors, bio_allowed_max_sectors(lim));
        max_discard_sectors -= max_discard_sectors % granularity;
-
-       if (unlikely(!max_discard_sectors)) {
-               /* XXX: warn */
+       if (unlikely(!max_discard_sectors))
                return NULL;
-       }
 
        if (bio_sectors(bio) <= max_discard_sectors)
                return NULL;
-- 
2.39.2


Reply via email to