On Wed, 2023-11-22 at 11:25 +0800, Jiapeng Chong wrote: > Swap is a function interface that provides exchange function. To avoid > code duplication, we can use swap function. > > ./arch/um/os-Linux/sigio.c:81:28-29: WARNING opportunity for swap(). >
Hm. There's already a use of swap() here in this file, but I actually think we should revert that? This is basically userspace code, not kernel code, so I don't think it should include linux headers, even if those happen to be "standalone enough" right now to work. johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
