Hi Azeem, kernel test robot noticed the following build errors:
[auto build test ERROR on uml/next] [also build test ERROR on uml/fixes wireless-next/main wireless/main linus/master v6.4-rc4 next-20230530] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Azeem-Shaikh/uml-Replace-all-non-returning-strlcpy-with-strscpy/20230531-004115 base: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux next patch link: https://lore.kernel.org/r/20230530164004.986750-1-azeemshaikh38%40gmail.com patch subject: [PATCH] uml: Replace all non-returning strlcpy with strscpy config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20230531/202305311135.zgmt1gyr-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/c51d7beb37cfbda321feb3811bbe0e381f804899 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Azeem-Shaikh/uml-Replace-all-non-returning-strlcpy-with-strscpy/20230531-004115 git checkout c51d7beb37cfbda321feb3811bbe0e381f804899 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=um SUBARCH=i386 olddefconfig make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202305311135.zgmt1gyr-...@intel.com/ All errors (new ones prefixed by >>): arch/um/os-Linux/drivers/tuntap_user.c: In function 'tuntap_open': >> arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration >> of function 'strscpy'; did you mean 'strncpy'? >> [-Werror=implicit-function-declaration] 149 | strscpy(ifr.ifr_name, pri->dev_name, sizeof(ifr.ifr_name)); | ^~~~~~~ | strncpy cc1: some warnings being treated as errors vim +149 arch/um/os-Linux/drivers/tuntap_user.c 127 128 static int tuntap_open(void *data) 129 { 130 struct ifreq ifr; 131 struct tuntap_data *pri = data; 132 char *output, *buffer; 133 int err, fds[2], len, used; 134 135 err = tap_open_common(pri->dev, pri->gate_addr); 136 if (err < 0) 137 return err; 138 139 if (pri->fixed_config) { 140 pri->fd = os_open_file("/dev/net/tun", 141 of_cloexec(of_rdwr(OPENFLAGS())), 0); 142 if (pri->fd < 0) { 143 printk(UM_KERN_ERR "Failed to open /dev/net/tun, " 144 "err = %d\n", -pri->fd); 145 return pri->fd; 146 } 147 memset(&ifr, 0, sizeof(ifr)); 148 ifr.ifr_flags = IFF_TAP | IFF_NO_PI; > 149 strscpy(ifr.ifr_name, pri->dev_name, > sizeof(ifr.ifr_name)); 150 if (ioctl(pri->fd, TUNSETIFF, &ifr) < 0) { 151 err = -errno; 152 printk(UM_KERN_ERR "TUNSETIFF failed, errno = %d\n", 153 errno); 154 close(pri->fd); 155 return err; 156 } 157 } 158 else { 159 err = socketpair(AF_UNIX, SOCK_DGRAM, 0, fds); 160 if (err) { 161 err = -errno; 162 printk(UM_KERN_ERR "tuntap_open : socketpair failed - " 163 "errno = %d\n", errno); 164 return err; 165 } 166 167 buffer = get_output_buffer(&len); 168 if (buffer != NULL) 169 len--; 170 used = 0; 171 172 err = tuntap_open_tramp(pri->gate_addr, &pri->fd, fds[0], 173 fds[1], buffer, len, &used); 174 175 output = buffer; 176 if (err < 0) { 177 printk("%s", output); 178 free_output_buffer(buffer); 179 printk(UM_KERN_ERR "tuntap_open_tramp failed - " 180 "err = %d\n", -err); 181 return err; 182 } 183 184 pri->dev_name = uml_strdup(buffer); 185 output += IFNAMSIZ; 186 printk("%s", output); 187 free_output_buffer(buffer); 188 189 close(fds[0]); 190 iter_addresses(pri->dev, open_addr, pri->dev_name); 191 } 192 193 return pri->fd; 194 } 195 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
