All the idle routines are called with RCU disabled, as such there must
not be any tracing inside.

While there; clean-up the io-port idle thing.

Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Acked-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
Acked-by: Frederic Weisbecker <frede...@kernel.org>
Tested-by: Tony Lindgren <t...@atomide.com>
Tested-by: Ulf Hansson <ulf.hans...@linaro.org>
---
 drivers/acpi/processor_idle.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -109,8 +109,8 @@ static const struct dmi_system_id proces
 static void __cpuidle acpi_safe_halt(void)
 {
        if (!tif_need_resched()) {
-               safe_halt();
-               local_irq_disable();
+               raw_safe_halt();
+               raw_local_irq_disable();
        }
 }
 
@@ -525,8 +525,11 @@ static int acpi_idle_bm_check(void)
        return bm_status;
 }
 
-static void wait_for_freeze(void)
+static __cpuidle void io_idle(unsigned long addr)
 {
+       /* IO port based C-state */
+       inb(addr);
+
 #ifdef CONFIG_X86
        /* No delay is needed if we are in guest */
        if (boot_cpu_has(X86_FEATURE_HYPERVISOR))
@@ -571,9 +574,7 @@ static void __cpuidle acpi_idle_do_entry
        } else if (cx->entry_method == ACPI_CSTATE_HALT) {
                acpi_safe_halt();
        } else {
-               /* IO port based C-state */
-               inb(cx->address);
-               wait_for_freeze();
+               io_idle(cx->address);
        }
 
        perf_lopwr_cb(false);
@@ -595,8 +596,7 @@ static int acpi_idle_play_dead(struct cp
                if (cx->entry_method == ACPI_CSTATE_HALT)
                        safe_halt();
                else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) {
-                       inb(cx->address);
-                       wait_for_freeze();
+                       io_idle(cx->address);
                } else
                        return -ENODEV;
 



_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

Reply via email to