Hi Sudip and Dave,
Thanks for the great SRU template and contributing a patch!
I'll re-upload with minor, but relevant changes (please review), and
accept for Jammy.
The modified code is either already patched or no longer exists/has
changed in Mantic.
Changes:
- Setting the bug importance to High per [1].
- d/changelog: include filenames to describe the changes
- d/p/*.patch:
- `Origin:` should be `backport` as there are changes from upstream; see
DEP-3 [2]:
```"backport" (... upstream patch that had to be modified ...)```
- `Author:` added, considering the above, as some changes are yours, for
credit.
- For clarity, this could be done in 2 separate patches: one from upstream and
another one with your fixes (since upstream doesn't maintain a stable branch
where such changes could be submitted to, apparently; and linked
downstream).
But this is preference/style, not a requirement.
- The patch filename could use the `lpNUMBER-title.patch` format, with `title`
either coming from the upstream patch (if there's one, like this case) or
sometimes adding more specifics of the fix (e.g., as you did in
`Description`).
This, too, is preference/style, not a requirement, but it does help over
time.
cheers,
[1] https://wiki.ubuntu.com/Bugs/Importance
[2] https://dep-team.pages.debian.net/deps/dep3/
$ diff -U0 old.debdiff new.debdiff
--- old.debdiff 2024-03-04 12:51:10.000000000 +0000
+++ new.debdiff 2024-03-04 19:39:48.150692799 +0000
@@ -7 +7 @@
-+ * Fix crash on startup. (LP: #1971094)
++ * d/p/0009-Fix-runtime.patch: Fix crash on startup. (LP: #1971094)
@@ -32,2 +32,2 @@
-+
-+Origin: upstream,
https://github.com/OpenShot/openshot-qt/commit/cd69f2ad8d10c26b20eb9ae46bcc288f3c322b85
++Author: Sudip Mukherjee <sudipm.mukher...@gmail.com>
++Origin: backport,
https://github.com/OpenShot/openshot-qt/commit/cd69f2ad8d10c26b20eb9ae46bcc288f3c322b85
@@ -35 +35 @@
-+Last-Update: 2024-02-16
++Last-Update: 2024-03-04
** Changed in: openshot-qt (Ubuntu Jammy)
Importance: Undecided => High
** Changed in: openshot-qt (Ubuntu Jammy)
Status: Confirmed => Fix Committed
** Tags added: verification-needed verification-needed-jammy
--
You received this bug notification because you are a member of UBUNTU -
AL - BR, which is subscribed to OpenShot Video Editor.
https://bugs.launchpad.net/bugs/1971094
Title:
[SRU] openshot doesn't start Ubuntu 22.04 fresh install
Status in OpenShot Video Editor:
Fix Released
Status in openshot-qt package in Ubuntu:
Fix Released
Status in openshot-qt source package in Jammy:
Fix Committed
Bug description:
[ Impact ]
openshot is completely unusable as it will fail to start with the
following error:
Traceback (most recent call last):
File "/usr/bin/openshot-qt", line 33, in <module>
sys.exit(load_entry_point('openshot-qt==2.5.1', 'gui_scripts',
'openshot-qt')())
File "/usr/lib/python3/dist-packages/openshot_qt/launch.py", line 97, in
main
app = OpenShotApp(argv)
File "/usr/lib/python3/dist-packages/openshot_qt/classes/app.py", line 219,
in __init__
self.window = MainWindow(mode)
File "/usr/lib/python3/dist-packages/openshot_qt/windows/main_window.py",
line 2521, in __init__
self.timeline = TimelineWebView(self)
File
"/usr/lib/python3/dist-packages/openshot_qt/windows/views/timeline_webview.py",
line 3000, in __init__
self.cache_renderer.setInterval(0.5 * 1000)
TypeError: setInterval(self, int): argument 1 has unexpected type 'float'
version:INFO Found current version: {"error_rate_stable": 0.25,
"trans_rate_stable": 0.01, "error_rate_unstable": 0.05, "openshot_version":
"3.1.1", "trans_rate_unstable": 0.001}
[ Test Plan ]
Simple test:
* Execute openshot-qt, which will fail to start if its not fixed.
* With the fixed package, openshot-qt will start and the tutorial will show.
Detailed test:
* Import few videos or images
* right click on the thumbnail
* Click on "Add to timeline"
* the image or the video should now be added to the timeline
* add few such images and videos
* Try playing the timeline
[ Where problems could occur ]
The problem was caused because float is used as some of the arguments
where int is now expected. There can be some more such parts in the
code which I might have missed during my testing. And if any such code
is executed with a float argument then the application might again
crash.
[ Other Info ]
* As mentioned in the patch, part of the patch is from upstream. Similar
changes have been done in few more places which I found during testing.
[ Original Bug Description ]
openshot doesn't start on Ubuntu 22.04 ( after fresh Ubuntu install )
This is message in Terminal:
openshot-qt
Loaded modules from installed directory:
/usr/lib/python3/dist-packages/openshot_qt
app:INFO ------------------------------------------------
app:INFO Sun May 1 19:44:47 2022
app:INFO Starting new session
app:INFO ------------------------------------------------
app:INFO OpenShot (version 2.5.1)
app:INFO ------------------------------------------------
app:INFO openshot-qt version: 2.5.1
app:INFO libopenshot version: 0.2.5
app:INFO platform: Linux-5.15.0-27-generic-x86_64-with-glibc2.35
app:INFO processor: x86_64
app:INFO machine: x86_64
app:INFO python version: 3.10.4
app:INFO qt5 version: 5.15.3
app:INFO pyqt5 version: 5.15.6
metrics:ERROR Error determining OS version in metrics.py
language:INFO Qt Detected Languages: ['de-DE']
language:INFO LANG Environment Variable: de_DE.UTF-8
language:INFO LOCALE Environment Variable:
language:INFO OpenShot Preference Language: Default
project_data:INFO Setting default profile to HD 720p 30 fps
app:INFO Setting font to Cantarell
logger_libopenshot:INFO Connecting to libopenshot with debug port: 5556
app:INFO Setting custom dark theme
QMainWindow::addDockWidget: invalid 'area' argument
ui_util:INFO Initializing UI for MainWindow
exceptions:ERROR Unhandled Exception
Traceback (most recent call last):
File "/usr/bin/openshot-qt", line 33, in <module>
sys.exit(load_entry_point('openshot-qt==2.5.1', 'gui_scripts',
'openshot-qt')())
File "/usr/lib/python3/dist-packages/openshot_qt/launch.py", line 97, in
main
app = OpenShotApp(argv)
File "/usr/lib/python3/dist-packages/openshot_qt/classes/app.py", line 219,
in __init__
self.window = MainWindow(mode)
File "/usr/lib/python3/dist-packages/openshot_qt/windows/main_window.py",
line 2521, in __init__
self.timeline = TimelineWebView(self)
File
"/usr/lib/python3/dist-packages/openshot_qt/windows/views/timeline_webview.py",
line 3000, in __init__
self.cache_renderer.setInterval(0.5 * 1000)
TypeError: setInterval(self, int): argument 1 has unexpected type 'float'
version:INFO Found current version: {"trans_rate_stable": 0.01,
"error_rate_stable": 0.16, "openshot_version": "2.6.1", "trans_rate_unstable":
0.001, "error_rate_unstable": 0.05}
ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: openshot-qt 2.5.1+dfsg1-2
ProcVersionSignature: Ubuntu 5.15.0-27.28-generic 5.15.30
Uname: Linux 5.15.0-27-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu82
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: ubuntu:GNOME
Date: Sun May 1 19:41:59 2022
InstallationDate: Installed on 2022-05-01 (0 days ago)
InstallationMedia: Ubuntu 22.04 LTS "Jammy Jellyfish" - Release amd64
(20220419)
PackageArchitecture: all
ProcEnviron:
TERM=xterm-256color
PATH=(custom, no user)
XDG_RUNTIME_DIR=<set>
LANG=de_DE.UTF-8
SHELL=/bin/bash
SourcePackage: openshot-qt
UpgradeStatus: No upgrade log present (probably fresh install)
To manage notifications about this bug go to:
https://bugs.launchpad.net/openshot/+bug/1971094/+subscriptions
--
Mailing list: https://launchpad.net/~linux-traipu
Post to : linux-traipu@lists.launchpad.net
Unsubscribe : https://launchpad.net/~linux-traipu
More help : https://help.launchpad.net/ListHelp
