Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Syntax error in the !CONFIG_MODULES fallback definition of add_taint_module(). --
commit e590786e5c6c86656ecff2a254d3a27b11cc2eb2 Author: Greg Kroah-Hartman <[email protected]> module: pull out add_taint_module() to be public This commit makes add_taint_module() global so that other kernel code can call it. When loadable modules are disabled, it defaults to a direct call to add_taint(). > diff --git a/include/linux/module.h b/include/linux/module.h > --- a/include/linux/module.h > +++ b/include/linux/module.h [ ... ] > @@ -877,6 +881,12 @@ static inline bool module_is_coming(struct module *mod) > static inline void module_for_each_mod(int(*func)(struct module *mod, void > *data), void *data) > { > } > + > +static inline void add_taint_module(struct module *mod, unsigned flag, > + enum lockdep_ok, lockdep_ok) [Severity: Low] Does this introduce a syntax error for !CONFIG_MODULES builds? It appears there is a comma instead of a space between the type and the variable name in the parameter list (enum lockdep_ok, lockdep_ok). This will cause a build failure when configuring the kernel with CONFIG_MODULES=n. > +{ > + add_taint(flag, lockdep_ok); > +} > #endif /* CONFIG_MODULES */ -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
