On 8/8/2026 5:52 AM, Ackerley Tng via B4 Relay wrote:
> From: Sean Christopherson <[email protected]>
> 
> Using kvm_mem_is_private() when populating guest_memfd instead of using an

Nit:
Using -> Use?
> open coded equivalent.  In addition to simplifying the populate code *now*,
> this avoids the need to provide a range-based gmem lookup API in the future
> as well.
> 
> No functional change intended.
> 
> Suggested-by: Xiaoyao Li <[email protected]>
> Signed-off-by: Sean Christopherson <[email protected]>
> Signed-off-by: Ackerley Tng <[email protected]>

Reviewed-by: Binbin Wu <[email protected]>

> ---
>  virt/kvm/guest_memfd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c
> index b596486d184ca..a11cf6dc785da 100644
> --- a/virt/kvm/guest_memfd.c
> +++ b/virt/kvm/guest_memfd.c
> @@ -811,9 +811,7 @@ static long __kvm_gmem_populate(struct kvm *kvm, struct 
> kvm_memory_slot *slot,
>  
>       folio_unlock(folio);
>  
> -     if (!kvm_range_has_memory_attributes(kvm, gfn, gfn + 1,
> -                                          KVM_MEMORY_ATTRIBUTE_PRIVATE,
> -                                          KVM_MEMORY_ATTRIBUTE_PRIVATE)) {
> +     if (!kvm_mem_is_private(kvm, gfn)) {
>               ret = -EINVAL;
>               goto out_put_folio;
>       }
> 


Reply via email to