On 06/29, Jiri Olsa wrote:
>
> --- a/arch/x86/kernel/uprobes.c
> +++ b/arch/x86/kernel/uprobes.c
> @@ -265,6 +265,10 @@ static bool is_prefix_bad(struct insn *insn)
>
> attr = inat_get_opcode_attribute(p);
> switch (attr) {
> + case INAT_MAKE_PREFIX(INAT_PFX_CS):
> + if (insn->x86_64)
> + break;
> + fallthrough;
> case INAT_MAKE_PREFIX(INAT_PFX_ES):
> case INAT_MAKE_PREFIX(INAT_PFX_DS):
> case INAT_MAKE_PREFIX(INAT_PFX_SS):
>
> or we could just skip it for nop10.. maybe that's better
Well, if you ask me I'd agree with the "maybe that's better" plan ;)
I mean... I don't think that INAT_PFX_CS should be "special" in is_prefix_bad.
But, whatever you do - I agree, feel free to keep my r-b.
Oleg.
