Re: [PATCH v5 1/2] blk-mq: add tracepoint block_rq_tag_wait

[Aaron Tomlin]

On Mon, Apr 27, 2026 at 12:38:48PM -0400, Steven Rostedt wrote:
> On Sun, 26 Apr 2026 22:01:41 -0400
> Aaron Tomlin <atom...@atomlin.com> wrote:
> 
> > +TRACE_EVENT(block_rq_tag_wait,
> > +
> > +   TP_PROTO(struct request_queue *q, struct blk_mq_hw_ctx *hctx, bool 
> > is_sched_tag),
> > +
> > +   TP_ARGS(q, hctx, is_sched_tag),
> > +
> > +   TP_STRUCT__entry(
> > +           __field( dev_t,         dev                     )
> > +           __field( u32,           hctx_id                 )
> > +           __field( u32,           nr_tags                 )
> > +           __field( bool,          is_sched_tag            )
> > +   ),
> > +
> > +   TP_fast_assign(
> > +           __entry->dev            = q->disk ? disk_devt(q->disk);
> 
> Hmm, does the above even compile?
> 
Hi Steve,

        TP_fast_assign(
                __entry->dev            = q->disk ? disk_devt(q->disk) : 0;

I embarrassingly dropped ": 0" from the ternary operator while preparing
the v5 patch and failed to catch the syntax error before sending it out.

I will fix the syntax, verify the build and spin a v6.


Kind regards,
-- 
Aaron Tomlin

signature.asc
Description: PGP signature