From: NeilBrown <[email protected]> "Best practice" is to use d_splice_alias() at the end of a ->lookup function. d_add() often works and is not incorrect in configfs, but as it is planned to remove d_add(), change to use d_splice_alias().
Signed-off-by: NeilBrown <[email protected]> --- fs/configfs/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index c82eca0b5d73..6ec589b6b8a4 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -501,8 +501,7 @@ static struct dentry * configfs_lookup(struct inode *dir, } spin_unlock(&configfs_dirent_lock); done: - d_add(dentry, inode); - return NULL; + return d_splice_alias(inode, dentry); } /* -- 2.50.0.107.gf914562f5916.dirty
