On 3/3/26 3:13 AM, Jingyuan Liang wrote:
Documentation describes the required and optional properties for
implementing Device Tree for a Microsoft G6 Touch Digitizer that
supports HID over SPI Protocol 1.0 specification.
[…]
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - microsoft,g6-touch-digitizer
+          - const: hid-over-spi
+      - description: Just "hid-over-spi" alone is allowed, but not recommended.
[…]
+required:
+  - compatible
+  - interrupts
+  - reset-gpios

Why is reset required? Is it so implausible on some device implementing the spec there wouldn't be a reset gpio?

+  - vdd-supply
Linux makes up a dummy regulator if DT doesn't provide one, so can regulators even be required?
[…]
+        compatible = "hid-over-spi";
Not following your own recommendation from above :)
+        reg = <0x0>;
+        interrupts-extended = <&gpio 42 IRQ_TYPE_EDGE_FALLING>;
+        reset-gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
+        vdd-supply = <&pm8350c_l3>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&ts_d6_reset_assert &ts_d6_int_bias>;

Heh, "reset_assert" is a name implying it would actually set the value from the pinctrl properties, which is what had to be done before reset-gpios were supported. But now reset-gpios are supported.


Thanks,
~val


P.S. happy to see work on this happen again!


Reply via email to