This series fixes 3 issue in rtla timerlat and osnoise parsing.
1. Fix buffer overflow when using --on-threshold option. Currently
passing `--on-threshold trace` causes rtla timerlat to segfault.
First patch addresses this issue.
2. Make -C/--cgroup option more user-friendly. Currently rtla timerlat
and osnoise parses does not allow to specify tracer's threads cgroup
name as `-C [cgroup]` or `--cgroup [cgroup]`. Second patch fixes this
by allowing users to specify cgroup in the aforementioned manner.
3. When specifying `-t/--trace` before `-a/--auto`, trace filename is
override to default <osnoise|timerlat>_trace.txt. For example, when
running rtla as
`rtla timerlat top -t custom_file.txt -a 100`
when the threshold is reached, timerlat_trace.txt file is created
instead of specified custom_file.txt. Third patch addresses this
issue.
changes v2 -> v3:
- Combined common logic into a utility function to parse optional
argument value
- Removed change that removed `clear_terminal`
changes v1 -> v2:
- Moved removing clear_terminal from `fix -C/--cgroup interface`
patch to `fix -a overriding -t argument` patch
- Added clarification why to remove clear_terminal
- Added `Fixes:` tag to the `fix -C/--cgroup interface` patch
v2:
https://lore.kernel.org/all/cover.1755018581.git.ipravdin.offic...@gmail.com/
v1:
https://lore.kernel.org/all/cover.1755014784.git.ipravdin.offic...@gmail.com/
Ivan Pravdin (3):
rtla: fix buffer overflow in actions_parse
rtla: fix -C/--cgroup interface
rtla: fix -a overriding -t argument
Documentation/tools/rtla/common_options.rst | 2 +-
tools/tracing/rtla/src/actions.c | 2 +-
tools/tracing/rtla/src/osnoise_hist.c | 29 +++++++--------------
tools/tracing/rtla/src/osnoise_top.c | 29 +++++++--------------
tools/tracing/rtla/src/timerlat_hist.c | 29 +++++++--------------
tools/tracing/rtla/src/timerlat_top.c | 29 +++++++--------------
tools/tracing/rtla/src/utils.c | 26 ++++++++++++++++++
tools/tracing/rtla/src/utils.h | 1 +
8 files changed, 65 insertions(+), 82 deletions(-)
--
2.48.1
