On Tue, 29 Jul 2025 14:10:35 +0900
"Masami Hiramatsu (Google)" <[email protected]> wrote:
> static void update_event_fields(struct trace_event_call *call,
> struct trace_eval_map *map)
> {
> struct ftrace_event_field *field;
> + const char *eval_string = NULL;
> struct list_head *head;
> + int len = 0;
> char *ptr;
> char *str;
> - int len = strlen(map->eval_string);
>
> /* Dynamic events should never have field maps */
> - if (WARN_ON_ONCE(call->flags & TRACE_EVENT_FL_DYNAMIC))
> + if (call->flags & TRACE_EVENT_FL_DYNAMIC)
> return;
Is there a reason you removed the WARN_ON_ONCE()?
Even for the attribute, this shouldn't be called by dynamic events. Or
do you know of a case?
-- Steve
