On Tue, 7 Jan 2025 15:48:20 +0100
Tomas Glozar <tglo...@redhat.com> wrote:
> The patchset makes both rtla-timerlat-hist and rtla-timerlat-top set
> OSNOISE_WORKLOAD to the proper value ("on" when running with -k, "off"
> when running with -u) every time the option is available instead of setting it
> only when running with -u.
>
> This prevents rtla timerlat -k from giving no results when
> NO_OSNOISE_WORKLOAD is set, either manually or by an abnormally exited earlier
> run of rtla timerlat -u.
>
> osnoise_set_workload is made to distinguish between the option missing
> altogether and it failing to be set. In the first case, rtla-timerlat will
> ignore setting the option to preserve compatibility of kernel-thread mode
> on older kernels without the OSNOISE_WORKLOAD option.
>
> Tomas Glozar (3):
> rtla/osnoise: Distinguish missing workload option
> rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads
> rtla/timerlat_top: Set OSNOISE_WORKLOAD for kernel threads
>
> tools/tracing/rtla/src/osnoise.c | 2 +-
> tools/tracing/rtla/src/timerlat_hist.c | 15 +++++++++------
> tools/tracing/rtla/src/timerlat_top.c | 15 +++++++++------
> 3 files changed, 19 insertions(+), 13 deletions(-)
>
BTW, are you going to be implementing any selftests for rtla so that it is
easy to test these changes and check for regressions?
-- Steve
