On Fri, 20 Dec 2024 15:48:44 +0200 Andy Shevchenko <andy.shevche...@gmail.com> wrote:
> пʼятниця, 20 грудня 2024 р. Steven Rostedt <rost...@goodmis.org> пише: > > > On Fri, 20 Dec 2024 08:56:44 +0200 > > Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > > > > > diff --git a/include/linux/string.h b/include/linux/string.h > > > > index 493ac4862c77..c995f973a59a 100644 > > > > --- a/include/linux/string.h > > > > +++ b/include/linux/string.h > > > > @@ -10,6 +10,7 @@ > > > > #include <linux/err.h> /* for ERR_PTR() */ > > > > #include <linux/errno.h> /* for E2BIG */ > > > > #include <linux/overflow.h> /* for check_mul_overflow() */ > > > > +#include <linux/cleanup.h> /* for DEFINE_FREE() */ > > > > > > > > > > > > Can you keep it ordered? > > > > Not sure what order you want to keep? > > > > > > > > > > > > #include <linux/stdarg.h> > > > > #include <uapi/linux/string.h> > > > > > > > > > > #include <linux/args.h> > > #include <linux/array_size.h> > > > > If you put it here it would make more like alphabetical order with only few > exceptions Sure, I'll send out a v2. Thanks for the review. --Steve > > #include <linux/compiler.h> /* for inline */ > > #include <linux/types.h> /* for size_t */ > > #include <linux/stddef.h> /* for NULL */ > > #include <linux/err.h> /* for ERR_PTR() */ > > #include <linux/errno.h> /* for E2BIG */ > > #include <linux/overflow.h> /* for check_mul_overflow() */ > > #include <linux/cleanup.h> /* for DEFINE_FREE() */ > > #include <linux/stdarg.h> > > #include <uapi/linux/string.h> > > > > It's not alphabetical, nor in x-mas tree order. I was never good at these > > "find the pattern" puzzles ;-) > > > > -- Steve > >
