Using scoped_guard() in the implementation of trace_##name() adds an
unnecessary level of indentation.

[ This is based on the series "tracing: Remove conditional locking from
  tracepoint". ]

Signed-off-by: Mathieu Desnoyers <mathieu.desnoy...@efficios.com>
Cc: Steven Rostedt <rost...@goodmis.org>
Cc: Linus Torvalds <torva...@linux-foundation.org>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: Michael Jeanson <mjean...@efficios.com>
Cc: Masami Hiramatsu <mhira...@kernel.org>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Alexei Starovoitov <a...@kernel.org>
Cc: Yonghong Song <y...@fb.com>
Cc: Paul E. McKenney <paul...@kernel.org>
Cc: Ingo Molnar <mi...@redhat.com>
Cc: Arnaldo Carvalho de Melo <a...@kernel.org>
Cc: Mark Rutland <mark.rutl...@arm.com>
Cc: Alexander Shishkin <alexander.shish...@linux.intel.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Andrii Nakryiko <andrii.nakry...@gmail.com>
Cc: b...@vger.kernel.org
Cc: Joel Fernandes <j...@joelfernandes.org>
Cc: Jordan Rife <jr...@google.com>
Cc: linux-trace-kernel@vger.kernel.org
---
 include/linux/tracepoint.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
index b2633a72e871..e398f6e43f61 100644
--- a/include/linux/tracepoint.h
+++ b/include/linux/tracepoint.h
@@ -259,8 +259,8 @@ static inline struct tracepoint 
*tracepoint_ptr_deref(tracepoint_ptr_t *p)
        {                                                               \
                if (static_branch_unlikely(&__tracepoint_##name.key)) { \
                        if (cond) {                                     \
-                               scoped_guard(preempt_notrace)           \
-                                       __DO_TRACE_CALL(name, TP_ARGS(args)); \
+                               guard(preempt_notrace)();               \
+                               __DO_TRACE_CALL(name, TP_ARGS(args));   \
                        }                                               \
                }                                                       \
                if (IS_ENABLED(CONFIG_LOCKDEP) && (cond)) {             \
@@ -275,8 +275,8 @@ static inline struct tracepoint 
*tracepoint_ptr_deref(tracepoint_ptr_t *p)
        {                                                               \
                might_fault();                                          \
                if (static_branch_unlikely(&__tracepoint_##name.key)) { \
-                       scoped_guard(rcu_tasks_trace)                   \
-                               __DO_TRACE_CALL(name, TP_ARGS(args));   \
+                       guard(rcu_tasks_trace)();                       \
+                       __DO_TRACE_CALL(name, TP_ARGS(args));           \
                }                                                       \
                if (IS_ENABLED(CONFIG_LOCKDEP)) {                       \
                        WARN_ONCE(!rcu_is_watching(),                   \
-- 
2.39.5


Reply via email to