> -----Original Message----- > From: David Laight <david.lai...@aculab.com> > Sent: Wednesday, 10 April 2019 6:45 PM > To: 'Alastair D'Silva' <alast...@au1.ibm.com>; alast...@d-silva.org > Cc: Jani Nikula <jani.nik...@linux.intel.com>; Joonas Lahtinen > <joonas.lahti...@linux.intel.com>; Rodrigo Vivi <rodrigo.v...@intel.com>; > David Airlie <airl...@linux.ie>; Daniel Vetter <dan...@ffwll.ch>; Karsten Keil > <i...@linux-pingi.de>; Jassi Brar <jassisinghb...@gmail.com>; Tom Lendacky > <thomas.lenda...@amd.com>; David S. Miller <da...@davemloft.net>; > Jose Abreu <jose.ab...@synopsys.com>; Kalle Valo > <kv...@codeaurora.org>; Stanislaw Gruszka <sgrus...@redhat.com>; > Benson Leung <ble...@chromium.org>; Enric Balletbo i Serra > <enric.balle...@collabora.com>; James E.J. Bottomley > <j...@linux.ibm.com>; Martin K. Petersen <martin.peter...@oracle.com>; > Greg Kroah-Hartman <gre...@linuxfoundation.org>; Alexander Viro > <v...@zeniv.linux.org.uk>; Petr Mladek <pmla...@suse.com>; Sergey > Senozhatsky <sergey.senozhat...@gmail.com>; Steven Rostedt > <rost...@goodmis.org>; Andrew Morton <a...@linux-foundation.org>; > intel-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; > ath...@lists.infradead.org; linux-wirel...@vger.kernel.org; linux- > s...@vger.kernel.org; linux-fb...@vger.kernel.org; > de...@driverdev.osuosl.org; linux-fsde...@vger.kernel.org > Subject: RE: [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be > separated by lines '|' > > From: Alastair D'Silva > > Sent: 10 April 2019 04:17 > > With the wider display format, it can become hard to identify how many > > bytes into the line you are looking at. > > > > The patch adds new flags to hex_dump_to_buffer() and > print_hex_dump() > > to print vertical lines to separate every N groups of bytes. > > > > eg. > > buf:00000000: 454d414e 43415053|4e495f45 00584544 > NAMESPAC|E_INDEX. > > buf:00000010: 00000000 00000002|00000000 00000000 ........|........ > > Ugg, that is just horrid. > It is enough to add an extra space if you really need the columns to be more > easily counted. >
I did consider that, but it would be a more invasive change, as the buffer length required would differ based on the flags. > I'm not even sure that is needed if you are printing 32bit words. > OTOH 32bit words makes 64bit values really stupid on LE systems. > Bytes with extra spaces every 4 bytes is the format I prefer even for long > lines. > > Oh, and if you are using hexdump() a lot you want a version that never uses > snprintf(). > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, > MK1 1PT, UK Registration No: 1397386 (Wales) > > > --- > This email has been checked for viruses by AVG. > https://www.avg.com
