On Wed, Aug 07, 2019 at 01:42:37PM +0200, Douglas Gilbert wrote: > + unsigned long fdev_bm[1]; /* see SG_FDEV_* defines above */
No need for the array of one here. > +#define SG_IS_DETACHING(sdp) test_bit(SG_FDEV_DETACHING, (sdp)->fdev_bm) > +#define SG_HAVE_EXCLUDE(sdp) test_bit(SG_FDEV_EXCLUDE, (sdp)->fdev_bm) No real need for these wrappers. Otherwise this looks sane to me.
