> +             struct scatterlist *sg = *cur_sg ?:
> +                             (struct scatterlist *)scsi_sglist(srb);
> +

No need for the cast here.  And I have to say I hate that GNU C
non-standard shortshut in ? :.

Why not simply:

                struct scatterlist *sg = *cur_sg;

                if (!sg)
                        sg = scsi_sglist(srb);

Which is a little more verbose, but much more readabe.

The rest of the patch looks fine to me.

Reply via email to