Re: [PATCH 1/1] qla2xxx: move IO flush to the front of NVME rport unregistration

[Bart Van Assche]

On 6/16/19 8:05 AM, Himanshu Madhani wrote:
+       INIT_WORK(&sess->free_work, qlt_free_session_done);
+       schedule_work(&sess->free_work);

Since you are touching this code and since there are multiple 
schedule_work() and flush_work() calls in the qla2xxx driver code for 
this work item: please move the INIT_WORK() call to the session 
initialization code. Calling INIT_WORK() while another thread can call 
schedule_work() or flush_work() on the same work item is racy.

Thanks,

Bart.