On 5/24/19 11:47 AM, Douglas Gilbert wrote: > Move code around so it has the basic ordering: open(), close(), > write(), read(), ioctl(), other system calls (e.g. mmap()), > support code and finally debug code. The change was to put the > write() associated code before the read() code. The write() > system call is associated with submitting SCSI commands (i.e. > writing metadata to the device). The read() system call is > associated with receiving the responses of earlier submitted > commands. > > Helper functions are often placed above their caller to reduce > the number of forward function declarations needed.
Moving helper functions in front of their caller is useful but random reordering of functions not. Such a random reordering of code pollutes the git history. Please don't do that. Thanks, Bart.
