Testing whether a pointer is not NULL after it has been dereferenced is
not useful. Hence remove the if (fcport) test. This was detected by
Coverity.

Cc: Himanshu Madhani <hmadh...@marvell.com>
Cc: Giridhar Malavali <gmalav...@marvell.com>
Signed-off-by: Bart Van Assche <bvanass...@acm.org>
---
 drivers/scsi/qla2xxx/qla_nvme.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 8dd6220857d4..5d9191278f41 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -186,10 +186,9 @@ static void qla_nvme_abort_work(struct work_struct *work)
        struct qla_hw_data *ha = fcport->vha->hw;
        int rval;
 
-       if (fcport)
-               ql_dbg(ql_dbg_io, fcport->vha, 0xffff,
-                   "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n",
-                   __func__, sp, sp->handle, fcport, fcport->deleted);
+       ql_dbg(ql_dbg_io, fcport->vha, 0xffff,
+              "%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n",
+              __func__, sp, sp->handle, fcport, fcport->deleted);
 
        if (!ha->flags.fw_started && (fcport && fcport->deleted))
                return;
-- 
2.21.0.196.g041f5ea1cf98

Reply via email to