Re: [PATCH 01/15] qla2xxx: Set the SCSI command result before calling the command done

[Bart Van Assche]

On Thu, 2019-03-28 at 10:09 -0700, Himanshu Madhani wrote:
> From: Giridhar Malavali <gmalav...@marvell.com>
> 
> This patch sets SCSI cmd->result before scsi_done() is called.
> 
> Signed-off-by: Giridhar Malavali <gmalav...@marvell.com>
> Signed-off-by: Himanshu Madhani <hmadh...@marvell.com>
> ---
>  drivers/scsi/qla2xxx/qla_os.c | 3 +-
>  1 file changed, 1 insertion(), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index a58a2885fb70..34db83b6f932 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> ﯦｶ뢯窻㾱쬢ﺩ嫛ᱱﺩ媢윻 窪嚶읍_sp_compl(void *ptr, int res)
>       srb_t *sp = ptr;
>       struct scsi_cmnd *cmd = GET_CMD_SP(sp);
>  
> -     cmd->result = res;
> -
>       if (atomic_read(&sp->ref_count) == 0) {
>               ql_dbg(ql_dbg_io, sp->vha, 0x3015,
>                   "SP reference-count to ZERO -- sp=%p cmd=%p.n",
> @@ -779,6 ﮪ嚶읍_sp_compl(void *ptr, int res)
>               return;
>  
>       sp->free(sp);
>       cmd->result = res;
>       cmd->scsi_done(cmd);

Hi Giridhar,

A patch description should not only explain what is changed but also why a
change has been made. What is the reason that you want to make this change?

Thanks,

Bart.