When trying to display tgt_counters in the debugfs, a panic can result. 

There is no null check for qpair after it is assigned in the for-loop. 
Unless vha->hw->queue_pair_map array is completely filled with entries, 
the system will panic dereferencing a null pointer.

Signed-off-by: Bill Kuzeja <william.kuz...@stratus.com>
---
 drivers/scsi/qla2xxx/qla_dfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index 0b19008..d647760 100644
--- a/drivers/scsi/qla2xxx/qla_dfs.c
+++ b/drivers/scsi/qla2xxx/qla_dfs.c
@@ -193,6 +193,8 @@
 
        for (i = 0; i < vha->hw->max_qpairs; i++) {
                qpair = vha->hw->queue_pair_map[i];
+               if (!qpair)
+                       continue;
                qla_core_sbt_cmd += qpair->tgt_counters.qla_core_sbt_cmd;
                core_qla_que_buf += qpair->tgt_counters.core_qla_que_buf;
                qla_core_ret_ctio += qpair->tgt_counters.qla_core_ret_ctio;
-- 
1.8.3.1

Reply via email to