On Tue, 2019-02-26 at 16:00 +0100, Hannes Reinecke wrote: > From: Hannes Reinecke <[email protected]> > > no_scsi2_lun_in_cdb declares a new bitfield, but we should > rather move it to the existing bitfield for better alignment. > > Signed-off-by: Hannes Reinecke <[email protected]> > --- > include/scsi/scsi_host.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h > index 83ce8580f150..86f09eeb7d72 100644 > --- a/include/scsi/scsi_host.h > +++ b/include/scsi/scsi_host.h > @@ -632,6 +632,9 @@ struct Scsi_Host { > /* Host responded with short (<36 bytes) INQUIRY result */ > unsigned short_inquiry:1; > > + /* The transport requires the LUN bits NOT to be stored in CDB[1] */ > + unsigned no_scsi2_lun_in_cdb:1; > + > /* > * Optional work queue to be utilized by the transport > */ > @@ -643,9 +646,6 @@ struct Scsi_Host { > */ > struct workqueue_struct *tmf_work_q; > > - /* The transport requires the LUN bits NOT to be stored in CDB[1] */ > - unsigned no_scsi2_lun_in_cdb:1; > - > /* > * Value host_blocked counts down from > */
Hi Hannes, Does this patch really affect the alignment of the structure members or does it rather reduce the structure size? Anyway, reducing the structure size looks like a good idea to me. Bart.
