On Wed, 2019-01-30 at 12:21 -0700, Jason Gunthorpe wrote:
> On Wed, Jan 30, 2019 at 10:59:34AM -0800, Bart Van Assche wrote:
> > On Tue, 2019-01-22 at 10:25 -0800, Bart Van Assche wrote:
> > > The default behavior of the SCSI core is to set the block layer request
> > > queue parameter max_segment_size to 64 KB. That means that elements of
> > > scatterlists are limited to 64 KB. Since RDMA adapters support larger
> > > sizes, increase max_segment_size for the SRP initiator.
> > >
> > > Notes:
> > > - The SCSI max_segment_size parameter was introduced in kernel v5.0. See
> > > also commit 50c2e9107f17 ("scsi: introduce a max_segment_size
> > > host_template parameters").
> > > - Some other block drivers already set max_segment_size to UINT_MAX,
> > > e.g. nbd and rbd.
> >
> > Hi Jason and Doug,
> >
> > Can one of you have a look at this patch?
>
> I was confused by the unanswered remark from Doug Gilbert - what that
> a request to change something?
Hi Jason,
My understanding is that Doug Gilbert's e-mail was not a request to change my
patch but instead an announcement of something he plans to implement in the
future. The functionality Doug mentioned seems useful to me but does not replace
this patch. It is much easier to users to have the default set correctly instead
of having to modify the default from the command line or from a udev rule.
Thanks,
Bart.
