On Fri, 19 Oct 2018 05:09:49 PDT (-0700), Christoph Hellwig wrote:
There is no good reason to duplicate the PCI menu in every architecture.
Instead provide a selectable HAVE_PCI symbol that indicates availability
of PCI support and the handle the rest in drivers/pci.

Note that for powerpc we now select HAVE_PCI globally instead of the
convoluted mess of conditional or or non-conditional support per board,
similar to what we do e.g. on x86.  For alpha PCI is selected for the
non-jensen configs as it was the default before, and a lot of code does
not compile without PCI enabled.  On other architectures with limited
PCI support that wasn't as complicated I've left the selection as-is.

Signed-off-by: Christoph Hellwig <h...@lst.de>
Acked-by: Max Filippov <jcmvb...@gmail.com>
Acked-by: Thomas Gleixner <t...@linutronix.de>
Acked-by: Bjorn Helgaas <bhelg...@google.com>

...

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index a344980287a5..071952cd4cae 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -39,8 +39,10 @@ config RISCV
        select SPARSE_IRQ
        select SYSCTL_EXCEPTION_TRACE
        select HAVE_ARCH_TRACEHOOK
+       select HAVE_PCI
        select MODULES_USE_ELF_RELA if MODULES
        select THREAD_INFO_IN_TASK
+       select PCI_MSI if PCI
        select RISCV_TIMER
        select GENERIC_IRQ_MULTI_HANDLER
        select ARCH_HAS_PTE_SPECIAL
@@ -216,28 +218,12 @@ source "kernel/Kconfig.hz"

 endmenu

-menu "Bus support"
-
-config PCI
-       bool "PCI support"
-       select PCI_MSI
-       help
-         This feature enables support for PCI bus system. If you say Y
-         here, the kernel will include drivers and infrastructure code
-         to support PCI bus devices.
-
-         If you don't know what to do here, say Y.
-
 config PCI_DOMAINS
        def_bool PCI

 config PCI_DOMAINS_GENERIC
        def_bool PCI

-source "drivers/pci/Kconfig"
-
-endmenu
-
 menu "Power management options"

 source kernel/power/Kconfig

Reviewed-by: Palmer Dabbelt <pal...@sifive.com>

I'm assuming this will go in via PCI tree of some sort, so I'm not going to touch it any further.

Thanks for cleaning this up!

Reply via email to