Re: [PATCH v4 4/7] target: consistently null-terminate t10_wwn.revision

[Bart Van Assche]

On Thu, 2018-11-29 at 02:01 +0100, David Disseldorp wrote:
>               strncpy(&dev->t10_wwn.revision[0],
> -                     dev->transport->inquiry_rev, 4);
> +                     dev->transport->inquiry_rev, INQUIRY_REVISION_LEN);
> +             dev->t10_wwn.revision[INQUIRY_REVISION_LEN] = '\0';

Can the above two statements be changed into a single strlcpy() call?

> -     memcpy(&wwn->revision[0], &buf[32], sizeof(wwn->revision));
> +     memcpy(&wwn->revision[0], &buf[32], INQUIRY_REVISION_LEN);
> +     wwn->revision[INQUIRY_REVISION_LEN] = '\0';

Have you considered to use snprintf(..., "%.*s", ...) instead?

Thanks,

Bart.