Hi Manish, Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nilesh-Javali/qedi-bug-fixes/20181121-022440 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-randconfig-x012-201846 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/scsi//qedi/qedi_main.c: In function 'qedi_ll2_process_skb': >> drivers/scsi//qedi/qedi_main.c:752:31: error: 'qedi_ll2_buf_size' undeclared >> (first use in this function); did you mean 'qedi_ll2_free_skbs'? pkt = udev->rx_pkt + (prod * qedi_ll2_buf_size); ^~~~~~~~~~~~~~~~~ qedi_ll2_free_skbs drivers/scsi//qedi/qedi_main.c:752:31: note: each undeclared identifier is reported only once for each function it appears in vim +752 drivers/scsi//qedi/qedi_main.c 727 728 /* map this skb to iscsiuio mmaped region */ 729 static int qedi_ll2_process_skb(struct qedi_ctx *qedi, struct sk_buff *skb, 730 u16 vlan_id) 731 { 732 struct qedi_uio_dev *udev = NULL; 733 struct qedi_uio_ctrl *uctrl = NULL; 734 struct qedi_rx_bd rxbd; 735 struct qedi_rx_bd *p_rxbd; 736 u32 rx_bd_prod; 737 void *pkt; 738 int len = 0; 739 u32 prod; 740 741 if (!qedi) { 742 QEDI_ERR(NULL, "qedi is NULL\n"); 743 return -1; 744 } 745 746 udev = qedi->udev; 747 uctrl = udev->uctrl; 748 749 ++uctrl->hw_rx_prod_cnt; 750 prod = (uctrl->hw_rx_prod + 1) % RX_RING; 751 > 752 pkt = udev->rx_pkt + (prod * qedi_ll2_buf_size); 753 len = min_t(u32, skb->len, (u32)LL2_SINGLE_BUF_SIZE); 754 memcpy(pkt, skb->data, len); 755 756 memset(&rxbd, 0, sizeof(rxbd)); 757 rxbd.rx_pkt_index = prod; 758 rxbd.rx_pkt_len = len; 759 rxbd.vlan_id = vlan_id; 760 761 uctrl->hw_rx_bd_prod = (uctrl->hw_rx_bd_prod + 1) % QEDI_NUM_RX_BD; 762 rx_bd_prod = uctrl->hw_rx_bd_prod; 763 p_rxbd = (struct qedi_rx_bd *)udev->ll2_ring; 764 p_rxbd += rx_bd_prod; 765 766 memcpy(p_rxbd, &rxbd, sizeof(rxbd)); 767 768 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_LL2, 769 "hw_rx_prod [%d] prod [%d] hw_rx_bd_prod [%d] rx_pkt_idx [%d] rx_len [%d].\n", 770 uctrl->hw_rx_prod, prod, uctrl->hw_rx_bd_prod, 771 rxbd.rx_pkt_index, rxbd.rx_pkt_len); 772 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_LL2, 773 "host_rx_cons [%d] hw_rx_bd_cons [%d].\n", 774 uctrl->host_rx_cons, uctrl->host_rx_bd_cons); 775 776 uctrl->hw_rx_prod = prod; 777 778 /* notify the iscsiuio about new packet */ 779 uio_event_notify(&udev->qedi_uinfo); 780 781 return 0; 782 } 783 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
