On 10/17/18 9:55 AM, Benjamin Block wrote:
> On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote:
>> Requires a few changes to the FC transport class as well.
>>
>> Cc: Johannes Thumshirn <jthumsh...@suse.de>
>> Cc: Benjamin Block <bbl...@linux.vnet.ibm.com>
>> Cc: linux-scsi@vger.kernel.org
>> Signed-off-by: Jens Axboe <ax...@kernel.dk>
>> ---
>> block/bsg-lib.c | 102 +++++++++++++++++--------------
>> drivers/scsi/scsi_transport_fc.c | 61 ++++++++++--------
>> 2 files changed, 91 insertions(+), 72 deletions(-)
>>
>
> Hey Jens,
>
> I haven't had time to look into this in any deep way - but I did plan to
> -, but just to see whether it starts and runs some I/O I tried giving it
> a spin and came up with nothing (see line 3 and 5):
I'm an idiot, can you try this on top?
diff --git a/block/bsg-lib.c b/block/bsg-lib.c
index 1aa0ed3fc339..95e12b635225 100644
--- a/block/bsg-lib.c
+++ b/block/bsg-lib.c
@@ -311,7 +311,7 @@ struct request_queue *bsg_setup_queue(struct device *dev,
const char *name,
int ret = -ENOMEM;
set = kzalloc(sizeof(*set), GFP_KERNEL);
- if (set)
+ if (!set)
return ERR_PTR(-ENOMEM);
set->ops = &bsg_mq_ops;
--
Jens Axboe
