On Sun, 2018-09-30 at 08:45 +0300, Avri Altman wrote: > +++ b/include/uapi/scsi/scsi_bsg_ufs.h > @@ -0,0 +1,74 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * TBD - UFS Transport SGIO v4 BSG Message Support > + * > + * Copyright (C) 2011-2013 Samsung India Software Operations > + */ > +#ifndef SCSI_BSG_UFS_H > +#define SCSI_BSG_UFS_H > + > +/* > + * This file intended to be included by both kernel and user space > + */ > + > +#define MAX_CDB_SIZE 16
Please rename this constant such that it has either "UFS" or "UTP" in its name. This name is too generic for a protocol-specific header file. Thanks, Bart.
