Hi Anil, I love your patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.19-rc5 next-20180926] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Add-FC-NVMe-Target-support/20180926-132955 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: powerpc-pseries_defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc Note: the linux-review/Himanshu-Madhani/qla2xxx-Add-FC-NVMe-Target-support/20180926-132955 HEAD ac552b3775986d6ba46be8dfa15cc47511c2e47c builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): In file included from drivers/scsi/qla2xxx/qla_nvmet.c:14:0: >> drivers/scsi/qla2xxx/qla_nvmet.h:30:25: error: field 'nvme_cmd_iu' has >> incomplete type struct atio7_nvme_cmnd nvme_cmd_iu; ^~~~~~~~~~~ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qlt_nvmet_ls_done': >> drivers/scsi/qla2xxx/qla_nvmet.c:48:46: error: 'struct <anonymous>' has no >> member named 'cmd' struct qla_nvmet_cmd *tgt_cmd = nvme->u.nvme.cmd; ^ drivers/scsi/qla2xxx/qla_nvmet.c:58:47: error: 'struct <anonymous>' has no member named 'cmd' sp, sp->vha, nvme->u.nvme.desc, nvme->u.nvme.cmd); ^ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_ls_rsp': >> drivers/scsi/qla2xxx/qla_nvmet.c:95:13: error: 'SRB_NVMET_LS' undeclared >> (first use in this function); did you mean 'SRB_NVME_LS'? sp->type = SRB_NVMET_LS; ^~~~~~~~~~~~ SRB_NVME_LS drivers/scsi/qla2xxx/qla_nvmet.c:95:13: note: each undeclared identifier is reported only once for each function it appears in >> drivers/scsi/qla2xxx/qla_nvmet.c:103:14: error: 'struct <anonymous>' has no >> member named 'exchange_address' nvme->u.nvme.exchange_address = tgt_cmd->atio.u.pt_ls4.exchange_address; ^ >> drivers/scsi/qla2xxx/qla_nvmet.c:103:49: error: 'union <anonymous>' has no >> member named 'pt_ls4' nvme->u.nvme.exchange_address = tgt_cmd->atio.u.pt_ls4.exchange_address; ^ >> drivers/scsi/qla2xxx/qla_nvmet.c:104:14: error: 'struct <anonymous>' has no >> member named 'nport_handle' nvme->u.nvme.nport_handle = tgt_cmd->atio.u.pt_ls4.nport_handle; ^ drivers/scsi/qla2xxx/qla_nvmet.c:104:45: error: 'union <anonymous>' has no member named 'pt_ls4' nvme->u.nvme.nport_handle = tgt_cmd->atio.u.pt_ls4.nport_handle; ^ >> drivers/scsi/qla2xxx/qla_nvmet.c:105:14: error: 'struct <anonymous>' has no >> member named 'vp_index' nvme->u.nvme.vp_index = tgt_cmd->atio.u.pt_ls4.vp_index; ^ drivers/scsi/qla2xxx/qla_nvmet.c:105:41: error: 'union <anonymous>' has no member named 'pt_ls4' nvme->u.nvme.vp_index = tgt_cmd->atio.u.pt_ls4.vp_index; ^ drivers/scsi/qla2xxx/qla_nvmet.c:107:14: error: 'struct <anonymous>' has no member named 'cmd' nvme->u.nvme.cmd = tgt_cmd; /* To be freed */ ^ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_fcp_abort': drivers/scsi/qla2xxx/qla_nvmet.c:178:13: error: 'SRB_NVMET_SEND_ABTS' undeclared (first use in this function); did you mean 'CF_NVME_ENABLE'? sp->type = SRB_NVMET_SEND_ABTS; ^~~~~~~~~~~~~~~~~~~ CF_NVME_ENABLE drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_create_targetport': >> drivers/scsi/qla2xxx/qla_nvmet.c:240:9: error: 'ql_dbg_nvme' undeclared >> (first use in this function); did you mean 'ql_dbg_timer'? ql_dbg(ql_dbg_nvme, vha, 0xe081, ^~~~~~~~~~~ ql_dbg_timer >> drivers/scsi/qla2xxx/qla_nvmet.c:250:10: error: 'struct scsi_qla_host' has >> no member named 'targetport' &vha->targetport); ^~ drivers/scsi/qla2xxx/qla_nvmet.c:257:41: error: 'struct scsi_qla_host' has no member named 'targetport' tport = (struct qla_nvmet_tgtport *)vha->targetport->private; ^~ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_delete': >> drivers/scsi/qla2xxx/qla_nvmet.c:276:18: error: 'volatile struct >> <anonymous>' has no member named 'nvmet_enabled'; did you mean >> 'nvme_enabled'? if (!vha->flags.nvmet_enabled) ^~~~~~~~~~~~~ nvme_enabled drivers/scsi/qla2xxx/qla_nvmet.c:278:9: error: 'struct scsi_qla_host' has no member named 'targetport' if (vha->targetport) { ^~ drivers/scsi/qla2xxx/qla_nvmet.c:279:42: error: 'struct scsi_qla_host' has no member named 'targetport' tport = (struct qla_nvmet_tgtport *)vha->targetport->private; ^~ drivers/scsi/qla2xxx/qla_nvmet.c:281:10: error: 'ql_dbg_nvme' undeclared (first use in this function); did you mean 'ql_dbg_timer'? ql_dbg(ql_dbg_nvme, vha, 0xe083, ^~~~~~~~~~~ ql_dbg_timer drivers/scsi/qla2xxx/qla_nvmet.c:284:37: error: 'struct scsi_qla_host' has no member named 'targetport' nvmet_fc_unregister_targetport(vha->targetport); ^~ >> drivers/scsi/qla2xxx/qla_nvmet.c:287:3: error: implicit declaration of >> function 'nvmet_release_sessions'; did you mean 'pci_release_regions'? >> [-Werror=implicit-function-declaration] nvmet_release_sessions(vha); ^~~~~~~~~~~~~~~~~~~~~~ pci_release_regions drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_handle_ls': >> drivers/scsi/qla2xxx/qla_nvmet.c:316:9: error: implicit declaration of >> function 'qla_nvmet_find_sess_by_s_id'; did you mean >> 'qla_nvmet_send_resp_ctio'? [-Werror=implicit-function-declaration] sess = qla_nvmet_find_sess_by_s_id(vha, look_up_sid); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ qla_nvmet_send_resp_ctio drivers/scsi/qla2xxx/qla_nvmet.c:316:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion] sess = qla_nvmet_find_sess_by_s_id(vha, look_up_sid); ^ drivers/scsi/qla2xxx/qla_nvmet.c:330:25: error: 'union <anonymous>' has no member named 'pt_ls4' memcpy(&tgt_cmd->atio.u.pt_ls4, pt_ls4, sizeof(struct pt_ls4_rx_unsol)); ^ drivers/scsi/qla2xxx/qla_nvmet.c:341:31: error: 'struct scsi_qla_host' has no member named 'targetport' ret = nvmet_fc_rcv_ls_req(vha->targetport, ^~ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_process_cmd': drivers/scsi/qla2xxx/qla_nvmet.c:373:32: error: 'struct scsi_qla_host' has no member named 'targetport' ret = nvmet_fc_rcv_fcp_req(vha->targetport, &tgt_cmd->cmd.fcp_req, ^~ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_handle_abts': drivers/scsi/qla2xxx/qla_nvmet.c:414:28: error: 'struct scsi_qla_host' has no member named 'targetport' nvmet_fc_rcv_fcp_abort(vha->targetport, &cmd->cmd.fcp_req); ^~ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_send_resp_ctio': >> drivers/scsi/qla2xxx/qla_nvmet.c:472:34: error: 'union <anonymous>' has no >> member named 'nvme_isp27' struct fcp_hdr *fchdr = &atio->u.nvme_isp27.fcp_hdr; ^ drivers/scsi/qla2xxx/qla_nvmet.c:493:13: error: 'SRB_NVMET_FCP' undeclared (first use in this function); did you mean 'SRB_NVME_LS'? sp->type = SRB_NVMET_FCP; ^~~~~~~~~~~~~ SRB_NVME_LS drivers/scsi/qla2xxx/qla_nvmet.c:497:23: error: 'struct <anonymous>' has no member named 'cmd' sp->u.iocb_cmd.u.nvme.cmd = cmd; ^ drivers/scsi/qla2xxx/qla_nvmet.c:501:10: error: 'ql_dbg_nvme' undeclared (first use in this function); did you mean 'ql_dbg_timer'? ql_dbg(ql_dbg_nvme, vha, 0x3067, ^~~~~~~~~~~ ql_dbg_timer drivers/scsi/qla2xxx/qla_nvmet.c:517:31: error: 'union <anonymous>' has no member named 'nvme_isp27' ctio->exchange_addr = atio->u.nvme_isp27.exchange_addr; ^ drivers/scsi/qla2xxx/qla_nvmet.c:521:19: error: 'union <anonymous>' has no member named 'nvme_isp27' c_flags = atio->u.nvme_isp27.attr << 9; ^ drivers/scsi/qla2xxx/qla_nvmet.c: In function 'qla_nvmet_send_abts_ctio': >> drivers/scsi/qla2xxx/qla_nvmet.c:747:13: error: 'SRB_NVMET_ABTS' undeclared >> (first use in this function); did you mean 'SRB_NVME_LS'? sp->type = SRB_NVMET_ABTS; ^~~~~~~~~~~~~~ SRB_NVME_LS drivers/scsi/qla2xxx/qla_nvmet.c:753:10: error: 'ql_dbg_nvme' undeclared (first use in this function); did you mean 'ql_dbg_timer'? ql_dbg(ql_dbg_nvme, vha, 0x3067, ^~~~~~~~~~~ ql_dbg_timer cc1: some warnings being treated as errors vim +/nvme_cmd_iu +30 drivers/scsi/qla2xxx/qla_nvmet.h 21 22 struct qla_nvmet_cmd { 23 union { 24 struct nvmefc_tgt_ls_req ls_req; 25 struct nvmefc_tgt_fcp_req fcp_req; 26 } cmd; 27 struct scsi_qla_host *vha; 28 void *buf; 29 struct atio_from_isp atio; > 30 struct atio7_nvme_cmnd nvme_cmd_iu; 31 uint16_t cmd_len; 32 spinlock_t nvme_cmd_lock; 33 struct list_head cmd_list; /* List of cmds */ 34 struct work_struct work; 35 36 struct scatterlist *sg; /* cmd data buffer SG vector */ 37 int sg_cnt; /* SG segments count */ 38 int bufflen; /* cmd buffer length */ 39 int offset; 40 enum dma_data_direction dma_data_direction; 41 uint16_t ox_id; 42 struct fc_port *fcport; 43 }; 44 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
