Re: [PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support

[Bart Van Assche]

On 09/14/18 14:28, Himanshu Madhani wrote:
diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c b/drivers/scsi/qla2xxx/qla_nvmet.c
new file mode 100644
[ ... ]
+#if    IS_ENABLED(CONFIG_NVME_TARGET_FC)
[ ... ]
+#endif

This style of using #if / #endif is not acceptable. Instead, 
drivers/scsi/qla2xxx/Makefile should be modified such that qla_nvmet.c 
is only built if CONFIG_NVME_TARGET_FC has been set.

Bart.