On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> + if (se_sess->se_tpg->se_tpg_tfo->sess_get_initiator_sid) {
> + len = snprintf(page, PAGE_SIZE, "%s 0x%6phN\n",
> + se_sess->se_node_acl->initiatorname,
> + &se_sess->sess_bin_isid);
> + } else {
> + len = snprintf(page, PAGE_SIZE, "%s\n",
> + se_sess->se_node_acl->initiatorname);
> + }
Hello Mike,
The general recommendation for configfs is that each attribute contains a
single value, just like for sysfs. Patch 11/15 exports two values through
a single attribute. Have you considered to split the above into two
attributes, namely the initiator name and the ISID? Can the initiator name
be changed into a soft link to the se_node_acl configfs directory to make
it easy for shell scripts to retrieve additional initiator configuration
information?
Thanks,
Bart.
