Tejun, On 2018/03/05 5:33, Tejun Heo wrote: > On Fri, Mar 02, 2018 at 04:40:18AM +0900, Damien Le Moal wrote: >> This series introduces changes to scsi and libata error handling for ZBC and >> ZAC >> devices. >> >> The first patch moves ZBC specific error handling in sd_zbc_complete() to a >> generic scsi error function that can be used also in libata (second patch). >> The >> goal of this change is to limit retries for commands that are identify as not >> worth retrying (know failure condition) for both scsi/ZBC and libata/ZAC. >> Without these two patches, only ZBC behaves nicely (commands that are known >> to >> fail are retried in the ZAC case). >> >> The following 2 snmall patches are simple fixes. >> >> The last 2 pacthes are improvements in libata error handling verbosity. >> >> Damien Le Moal (6): >> scsi: Introduce scsi_zbc_noretry_cmd() >> libata: Use scsi_zbc_noretry_cmd() for ZAC devices >> libata: Fix comment typo in ata_eh_analyze_tf() >> libata: Fix ata_err_string() >> libata: Honor RQF_QUIET flag >> libata: Be quiet when asked to > > Except for the nit on the last patch, ata part looks good to me. > Martin, how do you wanna route the SCSI part? > > Thanks.
Thanks for the review. I will send a V2 to correct the last patch. There is also a typo in the commit message of the first patch to correct. -- Damien Le Moal Western Digital Research
