> -----Original Message----- > From: Himanshu Jha [mailto:himanshujha199...@gmail.com] > Sent: Saturday, December 30, 2017 9:18 PM > To: martin.peter...@oracle.com; j...@linux.vnet.ibm.com > Cc: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; > shivasharan.srikanteshw...@broadcom.com; > megaraidlinux....@broadcom.com; linux-scsi@vger.kernel.org; linux- > ker...@vger.kernel.org; mcg...@kernel.org; Himanshu Jha > <himanshujha199...@gmail.com> > Subject: [PATCH] scsi: megaraid: Use zeroing memory allocator than > allocator/memset > > Use pci_zalloc_consistent for allocating zeroed memory and remove > unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > 0-day tested with no failures. > > Suggested-by: Luis R. Rodriguez <mcg...@kernel.org> > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 19 ++++++------------- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 5 ++--- > 2 files changed, 8 insertions(+), 16 deletions(-) >
Hi Himanshu, I can see one more allocation done in megasas_get_seq_num() that could make use of these changes. Rest of the changes looks fine. Also, there is a driver update patchset that I am planning to post today. Adding this patch first might require additional rebasing of this patchset. Would you be ok if I send a separate patch for this along with the change mentioned above once my patch series gets committed? That would save me some rebasing effort. :-) Thanks, Shivasharan
