Hannes,

> +             if (!strncmp(scmd->device->vendor, "EMC", 3) &&
> +                 !strncmp(scmd->device->model, "SYMMETRIX", 9) &&
> +                 (sshdr.asc == 0x44) && (sshdr.ascq == 0x0)) {
> +                     /*
> +                      * EMC Symmetrix returns 'Internal target failure'
> +                      * for a variety of internal issues, all of which
> +                      * can be recovered by retry.
> +                      */
> +                     return ADD_TO_MLQUEUE;
> +             }

It's decidedly awful to have vendor/model-specific triggers in
scsi_error.

What are the drawbacks of just always refiring on AC/0x44/ITF?

-- 
Martin K. Petersen      Oracle Linux Engineering

Reply via email to