Hey,

This code is older than git is so it probably doesn't matter.  But just
for laughs does anyone know what this should be?

        drivers/scsi/aic7xxx/aic7xxx_core.c:4807 ahc_init_scbdata()
        warn: integer overflow (literal): u32max + 1

drivers/scsi/aic7xxx/aic7xxx_core.c
  4794  
  4795          /*
  4796           * Create our DMA tags.  These tags define the kinds of device
  4797           * accessible memory allocations and memory mappings we will
  4798           * need to perform during normal operation.
  4799           *
  4800           * Unless we need to further restrict the allocation, we rely
  4801           * on the restrictions of the parent dmat, hence the common
  4802           * use of MAXADDR and MAXSIZE.
  4803           */
  4804  
  4805          /* DMA tag for our hardware scb structures */
  4806          if (ahc_dma_tag_create(ahc, ahc->parent_dmat, /*alignment*/1,
  4807                                 /*boundary*/BUS_SPACE_MAXADDR_32BIT + 1,
                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^
This is "0xffffffff + 1" which has an integer overflow so it's a
complicated way to say zero.

  4808                                 /*lowaddr*/BUS_SPACE_MAXADDR_32BIT,
  4809                                 /*highaddr*/BUS_SPACE_MAXADDR,
  4810                                 /*filter*/NULL, /*filterarg*/NULL,
  4811                                 AHC_SCB_MAX_ALLOC * sizeof(struct 
hardware_scb),
  4812                                 /*nsegments*/1,
  4813                                 /*maxsegsz*/BUS_SPACE_MAXSIZE_32BIT,
  4814                                 /*flags*/0, &scb_data->hscb_dmat) != 0) {
  4815                  goto error_exit;
  4816          }
  4817  
  4818          scb_data->init_level++;
  4819  

regards,
dan carpenter

Reply via email to