ibmvscsis always returned 0 for the tpg/tag, since it did not
parse the value passed in by the user.

When functions like ALUA members exports the value, it will
be incorrect because targetcli/rtslib starts the tpg numbering
at 1.

Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com>
Signed-off-by: Mike Christie <mchri...@redhat.com>
---
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c 
b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index 3571052..522d547 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3914,8 +3914,16 @@ static struct se_portal_group *ibmvscsis_make_tpg(struct 
se_wwn *wwn,
 {
        struct ibmvscsis_tport *tport =
                container_of(wwn, struct ibmvscsis_tport, tport_wwn);
+       u16 tpgt;
        int rc;
 
+       if (strstr(name, "tpgt_") != name)
+               return ERR_PTR(-EINVAL);
+       rc = kstrtou16(name + 5, 0, &tpgt);
+       if (rc)
+               return ERR_PTR(rc);
+       tport->tport_tpgt = tpgt;
+
        tport->releasing = false;
 
        rc = core_tpg_register(&tport->tport_wwn, &tport->se_tpg,
-- 
2.5.4 (Apple Git-61)

Reply via email to