On Wed, Apr 19, 2017 at 09:46:31PM -0700, jsmart2...@gmail.com wrote: > From: James Smart <jsmart2...@gmail.com> > > There are two versions of a structure for queue creation and setup that the > driver shares with FW. The driver was only treating as version 0. > > Verify WQ_CREATE with 128B WQEs in V0 and V1. > > Code review of another bug showed the driver passing > 128B WQEs and 8 pages in WQ CREATE and V0. > Code inspection/instrumentation showed that the driver > uses V0 in WQ_CREATE and if the caller passes queue->entry_size > 128B, the driver sets the hdr_version to V1 so all is good. > When I tested the V1 WQ_CREATE, the mailbox failed causing > the driver to unload. > > Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> > Signed-off-by: James Smart <james.sm...@broadcom.com> > ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
