On Tue, 2017-04-18 at 11:55 +0200, Maurizio Lombardi wrote: > This patch fixes a potential buffer overflow in lpfc_nvme_info_show(). > > Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com> > --- > drivers/scsi/lpfc/lpfc_attr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c > index 22819af..1ce252f 100644 > --- a/drivers/scsi/lpfc/lpfc_attr.c > +++ b/drivers/scsi/lpfc/lpfc_attr.c > @@ -181,7 +181,7 @@ > wwn_to_u64(vport->fc_nodename.u.wwn), > phba->targetport->port_id); > > - len += snprintf(buf + len, PAGE_SIZE, > + len += snprintf(buf + len, PAGE_SIZE - len, > "\nNVME Target: Statistics\n"); > tgtp = (struct lpfc_nvmet_tgtport *)phba->targetport->private; > len += snprintf(buf+len, PAGE_SIZE-len, > @@ -326,7 +326,7 @@ > } > spin_unlock_irq(shost->host_lock); > > - len += snprintf(buf + len, PAGE_SIZE, "\nNVME Statistics\n"); > + len += snprintf(buf + len, PAGE_SIZE - len, "\nNVME Statistics\n"); > len += snprintf(buf+len, PAGE_SIZE-len, > "LS: Xmt %016llx Cmpl %016llx\n", > phba->fc4NvmeLsRequests,
Reviewed-by: Ewan D. Milne <emi...@redhat.com>
