On 02/27/2017 11:27 PM, Bart Van Assche wrote: > On Wed, 2017-02-22 at 17:07 +0100, Hannes Reinecke wrote: >> spin_lock_irqsave(shost->host_lock, flags); >> + WARN_ON(shost->shost_state != SHOST_RUNNING && >> + shost->shost_state != SHOST_CANCEL && >> + shost->shost_state != SHOST_RECOVERY && >> + shost->shost_state != SHOST_CANCEL_RECOVERY); >> if (scsi_host_set_state(shost, SHOST_RECOVERY)) >> - if (scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY)) >> - goto out_unlock; >> + scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY); > > Please issue a warning if the second scsi_host_set_state() fails. And once > that failure triggers a warning, I don't think we need the newly added > WARN_ON() statement anymore. Something else that surprised me is that you > consistently use WARN_ON() instead of WARN_ON_ONCE() in this patch? > Okay, will be fixing it up.
> Otherwise this patch looks fine to me. > Thanks. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
