Hello,
Le 27/02/2017 à 12:22, Peter Senna Tschudin a écrit :
> On Sun, Feb 26, 2017 at 08:24:25PM +0100, Romain Perier wrote:
>> pci_pool_*() functions should be replaced by the corresponding functions
>> in the DMA pool API. This adds support to check for use of these pci
>> functions and display a warning when it is the case.
>>
> I guess Joe Perches did sent some comments for this one, did you address
> them?
See the changelog of 00/20 (for v2). I have already integrated his
comments :)
>
> Reviewed-by: Peter Senna Tschudin <peter.se...@collabora.com>
>> Signed-off-by: Romain Perier <romain.per...@collabora.com>
>> ---
>> scripts/checkpatch.pl | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index baa3c7b..f2c775c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -6064,7 +6064,14 @@ sub process {
>> WARN("USE_DEVICE_INITCALL",
>> "please use device_initcall() or more appropriate
>> function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
>> }
>> -
>> +# check for old PCI api pci_pool_*(), use dma_pool_*() instead
>> + if ($line =~
>> /\bpci_pool(?:_(?:create|destroy|alloc|zalloc|free)|)\b/) {
>> + if (WARN("USE_DMA_POOL",
>> + "please use the dma pool api or more
>> appropriate function instead of the old pci pool api\n" . $herecurr) &&
>> + $fix) {
>> + while ($fixed[$fixlinenr] =~
>> s/\bpci_pool(_(?:create|destroy|alloc|zalloc|free)|)\b/dma_pool$1/) {}
>> + }
>> + }
>> # check for various structs that are normally const (ops, kgdb, device_tree)
>> if ($line !~ /\bconst\b/ &&
>> $line =~ /\bstruct\s+($const_structs)\b/) {
>> --
>> 2.9.3
>>
