> -----Original Message-----
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Thursday, January 26, 2017 12:55 AM
> To: Raghava Aditya Renukunta
> <raghavaaditya.renuku...@microsemi.com>
> Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org; Dave Carroll <david.carr...@microsemi.com>; Gana
> Sridaran <gana.srida...@microsemi.com>; Scott Benesh
> <scott.ben...@microsemi.com>
> Subject: Re: [PATCH V2 04/24] aacraid: Added sa firmware support
> 
> EXTERNAL EMAIL
> 
> 
> On Wed, Jan 25, 2017 at 10:00:51AM -0800, Raghava Aditya Renukunta wrote:
> > sa_firmware adds the capability to differentiate the new SmartIOC family
> > of adapters from the series 8 and below.
> >
> > Signed-off-by: Raghava Aditya Renukunta
> <raghavaaditya.renuku...@microsemi.com>
> > Signed-off-by: Dave Carroll <david.carr...@microsemi.com>
> >
> > ---
> 
> [...]
> 
> > @@ -465,9 +473,13 @@ void aac_define_int_mode(struct aac_dev *dev)
> >               if (dev->max_msix > msi_count)
> >                       dev->max_msix = msi_count;
> >       }
> > -     dev->vector_cap =
> > -             (dev->scsi_host_ptr->can_queue + AAC_NUM_MGT_FIB) /
> > -             msi_count;
> > +     if (dev->comm_interface == AAC_COMM_MESSAGE_TYPE3 && dev-
> >sa_firmware)
> > +             dev->vector_cap = (dev->scsi_host_ptr->can_queue +
> > +                             AAC_NUM_MGT_FIB);
> 
> '+' has precedence before '=' and you do no multiplication here, so no
> brackets
> needed.

Noted , will remove it in the next patch series. 
 

> [...]
> 
> 
> --
> Johannes Thumshirn                                          Storage
> jthumsh...@suse.de                                +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to