>>>>> "Calvin" == Calvin Owens <calvinow...@fb.com> writes:
Calvin> Trivial non-functional changes for a couple annoying things: 1) Calvin> Functions local to files are not declared static, which is Calvin> frustrating when reading the code because it's non-obvious at Calvin> first glance what's actually called from other files. Calvin> 2) Set-but-unused variables abound, presumably to mask Calvin> -Wunused-result errors in the past. None of these are flagged Calvin> today though (with one exception noted below), so remove them. Calvin> Fixing (2) exposed the fact that we improperly ignore the return Calvin> value of scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing Calvin> the calling code to deal with the potential error is Calvin> non-trivial, so for now just WARN(). Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
