On 7/22/2016 6:32 PM, Bart Van Assche wrote:
On 07/22/16 17:23, James Smart wrote:
+    buf = kmalloc(len + 1, GFP_KERNEL);
+    if (!buf)
+        return -ENOMEM;
+    memcpy(buf, s->from, len);
+    buf[len] = '\0';

Hello James,

Have you considered to combine the above kmalloc() and memcpy() calls into a single kasprintf(GFP_KERNEL, "%.*s", len, s->from) call?

Bart.


No, I followed the example of existing parse functions in the file.

-- james


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to