Apologies for the delay. Patch looks good. Acked by: Anil Gurumurthy <anil.gurumur...@qlogic.com>
-----Original Message----- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: 06 May 2016 06:54 To: Dan Carpenter <dan.carpen...@oracle.com> Cc: Anil Gurumurthy <anil.gurumur...@qlogic.com>; Sudarsana Kalluru <sudarsana.kall...@qlogic.com>; James E.J. Bottomley <j...@linux.vnet.ibm.com>; Martin K. Petersen <martin.peter...@oracle.com>; linux-scsi <linux-scsi@vger.kernel.org>; kernel-janit...@vger.kernel.org Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling >>>>> "Dan" == Dan Carpenter <dan.carpen...@oracle.com> writes: Dan> The caller assumes that "itnim" is NULL on error and non-NULL on Dan> success but really "itnim" is uninitialized on error. This Dan> function should just use normal error handling where it returns Dan> zero on success and negative on failure. Anil, please review: https://patchwork.kernel.org/patch/8820751/ -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
