On Thu, 2016-03-31 at 11:05 -0700, Lee Duncan wrote: > These patches make the location of "/var/target" configurable, > though it still defauls to "/var/target". > > This configuration is accomplished via the configfs > top-level target attribute "dbroot", i.e. dumping > out "/sys/kernel/config/target/dbroot" will normally > return "/var/target". Writing to this attribute > changes the loation where the kernel looks for the > target database. > > ** NOTE/QUESTION: no sanity checks are done on the path passed in, > but it seems like *some* should be done. At least checking that > it's an abosolute path (i.e. starts with '/')? Opinions? >
Wrt to sanity checking db_root at configfs attribute store time, how about doing a filp_open() + S_DIR(f_inode->imode) + filp_close() of the requested path to verify it's really a directory..? Also, it would probably be a good idea to limit when db_root can be changed. Eg, only allow db_root to be changed when no active target fabric drivers have been registered (list_empty(g_tf_list)), and require userspace to set a different db_root after modprobe target_core_mod completes, but before any fabric drivers are loaded. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
