On 11/18/2015 09:35 AM, Finn Thain wrote: > The "failed" label in NCR5380_select() is not helpful. Some failures > return 0, others -1. Use return instead of goto to improve clarity and > brevity, like atari_NCR5380.c does. Fix the relevant comments. > > Signed-off-by: Finn Thain <fth...@telegraphics.com.au> > > --- > drivers/scsi/NCR5380.c | 30 ++++++++---------------------- > drivers/scsi/atari_NCR5380.c | 6 +++--- > 2 files changed, 11 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
