Hi Punit,

Aren't you missing the removal of the memset() as part of this conversion?


-matt

> On Oct 23, 2015, at 3:03 PM, Punit Vara <punitv...@gmail.com> wrote:
> 
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
> 
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
> 
> Signed-off-by: Punit Vara <punitv...@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_els.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 36bf58b..422c800 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4990,7 +4990,7 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct 
> lpfc_iocbq *cmdiocb,
>       if (RDP_NPORT_ID_SIZE !=
>                       be32_to_cpu(rdp_req->nport_id_desc.length))
>               goto rjt_logerr;
> -     rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> +     rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
>       if (!rdp_context) {
>               rjt_err = LSRJT_UNABLE_TPC;
>               goto error;

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to